Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add justfile, update pre-commit and github actions configs accordingly #10

Merged
merged 8 commits into from
Jan 24, 2024

Conversation

AlessandroMiola
Copy link
Owner

Summary:

Footnotes

  1. I would have liked to be able to invoke just commands on powershell (both locally and within the CI pipeline) for personal preference; while managing to make it work locally (being it sufficient to specify set shell := ["powershell.exe", "-c"] within the justfile as per the docs), I encountered some issues in making it work within the CI pipeline. My understanding is that:

    • given that the CI (Github Actions) workflow (typically) runs in a Linux environment, bash is the default shell there
    • when specifying powershell.exe as the shell in justfile, potential compatibility issues might arise as you try to use powershell syntax in bash
    • therefore, you should ensure alignment between the execution environment and the (typical) Linux environment in Github Actions.

    This said, my attempts to setup the CI steps so that they could run on powershell miserably failed:

    • specifying powershell to be the default shell at job level in actions.yaml didn't work
    • specifying each (relevant) step to be run on powershell didn't work
    • no matter what the default shell configuration was, taiki-e/install-action@just kept on running on bash (with no possibility to specify a with: shell: configuration)

    Need to explore it further!

  2. I ended up running just commands on bash (both locally and in the CI pipeline).

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6874112) 100.00% compared to head (e4bf404) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          220       220           
=========================================
  Hits           220       220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlessandroMiola AlessandroMiola merged commit 13f73fe into main Jan 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant